fix: readLines() dropping falsy values in S3 and Azure source streams#2249
Merged
norberttech merged 1 commit into1.xfrom Mar 6, 2026
Merged
fix: readLines() dropping falsy values in S3 and Azure source streams#2249norberttech merged 1 commit into1.xfrom
norberttech merged 1 commit into1.xfrom
Conversation
array_filter() without callback was removing lines containing '0' or empty strings, causing schema detection to produce different results compared to local filesystem.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2249 +/- ##
==========================================
+ Coverage 82.81% 83.02% +0.21%
==========================================
Files 1360 1360
Lines 50594 50596 +2
==========================================
+ Hits 41898 42006 +108
+ Misses 8696 8590 -106
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
array_filter() without callback was removing lines containing '0' or empty strings, causing schema detection to produce different results compared to local filesystem.